Closed calcaide closed 1 month ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
boundary-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 21, 2024 9:34pm |
boundary-ui-desktop | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 21, 2024 9:34pm |
Closing this PR until we get more capacity and can debug windows runner issues properly, more info within this comment
Description
Update: Mac and linux runs are a success!!! old warnings are gone but windows run is failing. I am working with #tech-gihub-runners teams to help debug, it is possible we are missing a visualstudio individual component, as per node-pty readme
Upgrade node-pty to latest beta.
Notice that we declare
^1.1.0-beta14
but1.1.0-beta7
gets resolved. That is ok because we want the latest beta compatible with our third party deps that also use node-tpy, so1.1.0-beta7
seems the safe one compatibility wise.How to Test
Screenshots
Old builds (build from 2.1.0 release) with
node-pty
warnings present in the 3 OS DC build process:Mac:
Windows:
Linux:
Test build of this branch (with node-pty, xterm and electron-forge upgrade):
Mac:
Linux:
Checklist