hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
87 stars 28 forks source link

Upgrade node-pty to beta version #2420

Closed calcaide closed 1 month ago

calcaide commented 2 months ago

Description

Update: Mac and linux runs are a success!!! old warnings are gone but windows run is failing. I am working with #tech-gihub-runners teams to help debug, it is possible we are missing a visualstudio individual component, as per node-pty readme

Upgrade node-pty to latest beta.

Notice that we declare ^1.1.0-beta14 but 1.1.0-beta7 gets resolved. That is ok because we want the latest beta compatible with our third party deps that also use node-tpy, so 1.1.0-beta7 seems the safe one compatibility wise.

How to Test

Screenshots

Old builds (build from 2.1.0 release) with node-pty warnings present in the 3 OS DC build process:

Mac: Screenshot 2024-07-31 at 3 45 18 PM

Windows: Screenshot 2024-07-31 at 3 43 54 PM

Linux: Screenshot 2024-07-31 at 3 44 57 PM

Test build of this branch (with node-pty, xterm and electron-forge upgrade):

Mac: Screenshot 2024-08-01 at 8 06 16 AM

Linux: Screenshot 2024-08-01 at 8 06 35 AM

Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 9:34pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 9:34pm
calcaide commented 1 month ago

Closing this PR until we get more capacity and can debug windows runner issues properly, more info within this comment