hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
87 stars 28 forks source link

fix: 🐛 targets not displaying even after they are cached #2429

Closed lisbet-alvarez closed 1 month ago

lisbet-alvarez commented 1 month ago

Description

The main issue is that the daemon returns empty array for targets since it times out. But even after the targets are finished getting cached, they are not displayed in the UI. That is because in first attempt to load the this.allTargets variable got set to empty array which was causing the this.makeAllTargetsQuery to not even run. As a result the this.showFilters check in the template was coming back as false.

Screenshots (if appropriate)

Before:

https://github.com/user-attachments/assets/77e9eb06-5f21-4e42-8780-f85bac467e52

After:

https://github.com/user-attachments/assets/0bee5a97-74ae-4b68-bd06-a0719cc0e78c

How to Test

Checklist

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:51pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 4:51pm
lisbet-alvarez commented 1 month ago

Should we also do the same in the sessions page? I think it also could have the same issue but a lot less likely?

ah i didn't check the sessions page, but thats a great point. Rn i looked and that page also retrieves allTargets and allSessions so we should modify as well