hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.

http://boundary-ui.vercel.app

Other

89 stars 29 forks source link

refactor: 💡 remove route-action usage for session recordings #2439

Closed lisbet-alvarez closed 3 months ago

lisbet-alvarez commented 3 months ago

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-12620

Description

Remove route-action usage for session recordings

Screenshots (if appropriate)

https://github.com/user-attachments/assets/6c64a83f-a7e2-4324-afa6-d05fcc8eb84a

How to Test

Create a session recording using DC & ssh Target
Create a storage policy that allows deletion
Apply that storage policy to the global scope
Navigate to session-recording
Click "Manage" -> "Re-apply storage policy"
Card should update with correct time in "Delete after" row
Click "Manage" -> "Delete"
Session recording should be removed
Checklist

[X] I have added before and after screenshots for UI changes
[ ] I have added JSON response output for API changes
[ ] I have added steps to reproduce and test for bug fixes in the description
[ ] I have commented on my code, particularly in hard-to-understand areas
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2024 4:52pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2024 4:52pm