hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.

http://boundary-ui.vercel.app

Other

89 stars 29 forks source link

chore: 🤖 update ember-cli-mirage #2458

Closed cameronperera closed 2 months ago

cameronperera commented 2 months ago

Description

This PR updates ember-cli-mirage to v3.0.3. This is a minor change that will help with updating packages for this dependabot alert.

Screenshots (if appropriate)

I saw this warning while running test. I removed the entry for fireworm from yarn.lock here and ran yarn install again. This cleared up the warning.

How to Test

Please navigate around the Admin UI and desktop client Vercel builds. I have done local testing and have not see any issues and this build was successful.

Checklist

[ ] I have added before and after screenshots for UI changes
[ ] I have added JSON response output for API changes
[ ] I have added steps to reproduce and test for bug fixes in the description
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2024 7:14pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 23, 2024 7:14pm

calcaide commented 2 months ago

@cameronperera I do see the build you link within the description has an error when generating release metadata. I am pretty sure it is not related, but I will feel more confident to approve this PR if we can do a run with all green (or just re-run the failed step there).

For context: The release metadata geneartion step is prettys straight forward, B-U-T the piece of software we use to do so is very picky (as it should) with namings, arch's and platforms. Sometimes, this job will fail because we changed something that affected the naming generation of a zip or a binary, which usually means we broke something else, that's why my comment above. I am pretty sure in this case is a hiccup, but I would like if you can re-run.

cameronperera commented 2 months ago

@cameronperera I do see the build you link within the description has an error when generating release metadata. I am pretty sure it is not related, but I will feel more confident to approve this PR if we can do a run with all green (or just re-run the failed step there).

For context: The release metadata geneartion step is prettys straight forward, B-U-T the piece of software we use to do so is very picky (as it should) with namings, arch's and platforms. Sometimes, this job will fail because we changed something that affected the naming generation of a zip or a binary, which usually means we broke something else, that's why my comment above. I am pretty sure in this case is a hiccup, but I would like if you can re-run.

I fixed the naming of my test release branch and that fixed the issue. I updated the description with the new build and it was successful all the way through!