hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
89 stars 29 forks source link

fix: πŸ› Fix windows hanging when client agent isn't running #2459

Closed ZedLi closed 2 months ago

ZedLi commented 2 months ago

Description

There was a change where we manually timeout requests to client agent status as currently it can take too long. However, it turns out out on windows, when a SIGTERM was sent to the client agent status it didn't actually return anything. On mac an error response was returned on stderr but because nothing was returned on windows, our handler for spawn was waiting indefinitely for a response.

This change seeks to at least always resolve the promise if the child process ends so a caller isn't waiting forever.

Screenshots (if appropriate)

How to Test

Run DC in windows without client agent running and it should not hang up when logging in and going to settings page.

Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
boundary-ui βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 22, 2024 9:35pm
boundary-ui-desktop βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 22, 2024 9:35pm