hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
89 stars 29 forks source link

chore: 🤖 upgrade jsonpointer to v5 #2465

Closed lisbet-alvarez closed 2 months ago

lisbet-alvarez commented 2 months ago

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-14212

Description

Manually force is-my-json-valid@^2.20.0 to resolve to v2.20.6 which upgrades its dependency on jsonpointer to v5. Resolves: #127 #78

How to Test

  1. yarn start in ui/admin
  2. yarn start:desktop in ui/desktop
  3. Release workflow passes using this branch

    Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:07pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:07pm
calcaide commented 2 months ago

None blocking comment: after upgrading dependencies, are we checking warnings when running yarn install? This PR did NOT add any new warnings, but I notice the amount of warnings incresead a bit and wanted to mention to keep an eye on them 😄

Thanks for the deps work!!

lisbet-alvarez commented 2 months ago

None blocking comment: after upgrading dependencies, are we checking warnings when running yarn install? This PR did NOT add any new warnings, but I notice the amount of warnings incresead a bit and wanted to mention to keep an eye on them 😄

Thanks for the deps work!!

Will do & good point, thanks for bringing this up!