hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
87 stars 28 forks source link

Upgrade ember a11y testing to v7 #2470

Closed lisbet-alvarez closed 3 weeks ago

lisbet-alvarez commented 3 weeks ago

Description

Upgrade ember-a11y-testing to v7 in order to remove downstream dependency on braces@^2.3.2 braces@^2.3.2 -> chokidar@^2.1.8 -> watchpack-chokidar2@^2.0.1 -> watchpack@^1.7.4 -> webpack@^4.43.0 -> ember-auto-import@^1.11.2, ember-auto-import@^1.12.0 -> ember-a11y-testing

Upgrade @ember/test-helpers to v3.3.1 since its a ember-a11y-testing peer dependency.

To fix build error below, manually forced @babel/core to resolve to newest version image

To fix sinon build error below upgraded to newest version. image

To fix babel runtime error below, upgraded ember-cli-babel to v8.2.0 image

Upgrade to ember-a11y-testing v7 causes new accessibility tests to run regarding the <summary/> having text to be accessible. In our tests, the text in the Rose::Header component has the <utilities.dropdown/> that was not rendering the authenticated user's username. This was due to use using authenticateSession in our tests without providing the username. As a result, this PR also adds the field with a value to the authentication helper.

How to Test

  1. yarn start in ui/admin validate it builds and runs properly
  2. yarn start:desktop in ui/desktop validate it builds and runs properly
  3. boundary-ui-releases test run

Checklist

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 7:52pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 7:52pm