test: 💍 add TODO for a11y violations

[cameronperera]

Description

This will help address the false negative a11y violations we are seeing when tests are run in dark mode.

// TODO: Failing due to a11y violation while in dark mode.
// Investigating issue with styles not properly
// being applied during test.
const session = this.owner.lookup('service:session');
session.set('data.theme', 'light');

You will see that I have repeated the above TODO and session lookup, sometimes in the same test file more than once. This is to ensure I am only changing it for that exact test and we can easily remove it from each test as we address these issues. I was going to use QUnit's test.todo but that would be for a WIP test that we expect to fail. With the change of the theme for the specific tests, they will pass every time now so test.todo doesn't exactly work here.

How to Test

To verify that this is working, pull down these changes, change system theme to dark, and run yarn test. All test should be passing as expected.

Checklist

• [ ] I have added before and after screenshots for UI changes
• [ ] I have added JSON response output for API changes
• [ ] I have added steps to reproduce and test for bug fixes in the description
• [ ] I have commented on my code, particularly in hard-to-understand areas
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 4, 2024 8:32pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 4, 2024 8:32pm

[cameronperera]

I was going to use QUnit's test.todo but that would be for a WIP test that we expect to fail. With the change of the theme for the specific tests, they will pass every time now so test.todo doesn't exactly work here.

You would just let it fail by not manually setting the theme in this case. But this also works fine

That was my original plan but technically the test are working as expected. Just the false negative from the a11yAudit so the test.todo felt incorrect here.