hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.

http://boundary-ui.vercel.app

Other

87 stars 28 forks source link

Upgrade node engines to work with node 20 and 21 #2486

Open calcaide opened 2 weeks ago

calcaide commented 2 weeks ago

Description

Upgrade node engines to work with node 20 and 21.

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 12, 2024 9:59pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 12, 2024 9:59pm

cameronperera commented 2 weeks ago

Since node 21 is already past it's maintenance window, should we try going straight to v22 instead?

DhariniJeeva commented 2 weeks ago

should we also consider using the same version in boundary-ui-releases?

calcaide commented 2 weeks ago

@cameronperera

Good point.

Some thinking loud:

Right now 20 is LTS, so we should keep node 20 support IMHO.
As you mention 22 is current.
So we should keep support for: 20 and 22.

is that correct?

cameronperera commented 2 weeks ago

@cameronperera

Good point.

Some thinking loud:

Right now 20 is LTS, so we should keep node 20 support IMHO.

As you mention 22 is current.

So we should keep support for: 20 and 22.

is that correct?

Correct. If we are going to upgrade our supported node version, we should probably stick to the LTS versions. Plus v22 doesn't start it's maintenance schedule until a year from now. So this should hold us for a while.

calcaide commented 2 weeks ago

@cameronperera

Awesome!! pushing changes 😃

calcaide commented 2 weeks ago

@DhariniJeeva

We keep supporting node 20. For now, I will suggest to keep the pipeline with node 20. Upgrading node in the pipeline requires more work, specially testing. We just upgrade the pipeline from 18 to 20 so IMHo its fine for a while. Something I will like to explore once TS is released.

Thoughts?

DhariniJeeva commented 2 weeks ago

@DhariniJeeva

We keep supporting node 20. For now, I will suggest to keep the pipeline with node 20. Upgrading node in the pipeline requires more work, specially testing. We just upgrade the pipeline from 18 to 20 so IMHo its fine for a while. Something I will like to explore once TS is released.

Thoughts?

that sounds good!

calcaide commented 2 weeks ago

@DhariniJeeva Due to reverting the node20 upgrade changes within boundary-ui-releases I will hold this PR until we can run node20 within the pipeline.