hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
89 stars 29 forks source link

Update README.md for umask. #2492

Closed jboero closed 1 month ago

jboero commented 2 months ago

Build requires a umask 0022 which isn't the default in current security-focused enterprise distributions.

Description

Screenshots (if appropriate)

How to Test

Checklist

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 10:38am
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2024 10:38am
jboero commented 2 months ago

The buid error hit with default umask 0027:

✔ Running preMake hook
❯ Making distributables
  ✖ Making a zip distributable for linux/x64
  ✖ Making a deb distributable for linux/x64
    › Command failed with a non-zero return code (2):
      fakeroot dpkg-deb --build /tmp/electron-installer--336252-oRY4NjWWu6G5/boundary-desktop_0.0.0_amd64
      dpkg-deb: error: control directory has bad permissions 750 (must be >=0755 and <=0775)
◼ Running postMake hook

An unhandled rejection has occurred inside Forge:
Error: Command failed with a non-zero return code (2):
fakeroot dpkg-deb --build /tmp/electron-installer--336252-oRY4NjWWu6G5/boundary-desktop_0.0.0_amd64

dpkg-deb: error: control directory has bad permissions 750 (must be >=0755 and <=0775)
at ChildProcess.<anonymous> (/home/jboero/code/boundary-ui/ui/desktop/electron-app/node_modules/electron-installer-debian/node_modules/@malept/cross-spawn-promise/dist/src/index.js:99:24)
    at ChildProcess.emit (node:events:518:28)
    at ChildProcess.emit (node:domain:488:12)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
cameronperera commented 1 month ago

Thanks for your input. We do not typically accept these type of PRs as they do not apply to our internal build process. However, we are happy to add a note that users will need full permissions to build the desktop client locally. Again, we appreciate your input.

cameronperera commented 1 month ago

PR with comment about needing full permissions when building the desktop client