hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.

http://boundary-ui.vercel.app

Other

87 stars 28 forks source link

fix: show username first and then password when credentials are listed #2494

Closed DhariniJeeva closed 1 week ago

DhariniJeeva commented 1 week ago

✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15105

Description

This PR moves up username field

Screenshots (if appropriate)

before:

Screenshot 2024-09-17 at 6 37 46 PM

after:

Screenshot 2024-09-17 at 6 31 53 PM

with a JSON blob:

Screenshot 2024-09-18 at 6 22 21 PM

How to Test

Checklist

[x] I have added before and after screenshots for UI changes
~[ ] I have added JSON response output for API changes~
[x] I have added steps to reproduce and test for bug fixes in the description
[x] I have commented on my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2024 6:41pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 19, 2024 6:41pm

DhariniJeeva commented 1 week ago

I created this against main since this does not impact any TS changes, but let me know if you think otherwise, happy to move this to llb