hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.

http://boundary-ui.vercel.app

Other

87 stars 28 forks source link

small update to desktop README #2497

Closed cameronperera closed 6 days ago

cameronperera commented 1 week ago

Description

Small README update to let users know they will need full permissions when trying to build the desktop client locally.

Checklist

[ ] I have added before and after screenshots for UI changes
[ ] I have added JSON response output for API changes
[ ] I have added steps to reproduce and test for bug fixes in the description
[ ] I have commented on my code, particularly in hard-to-understand areas
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 4:05pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 23, 2024 4:05pm

jboero commented 6 days ago

This modification to my original PR is inadequate. "Full permissions" means nothing if umask isn't set correctly. Build will complain as directories are created with incorrect group permissiona during build. You can run this as an admin/wheel and in your own home directory and it will still fail if umask isn't set to 002