appupdater cli check

[calcaide]

Description

ICU-15109

Add check on the appUpdater to skip it if the Desktop client is NOT using the built in CLI.

IMPORTANT The first approach I tried was to use node fs.lstatSync. The issue I encounter is that the lstat object returned, in POSIX systems, the key file always false value. This happens because on POSIX system, the binary name we return is boundary without file extension, therefore the lstat object mark it as directory, whatever we were passing boundary or electron-app/cli/boundary.

Decided to rely on parsing the path. If the parsed object returns values for the keys dir and root, means it is indeed the CLI built in the desktop client.

Happy to discuss other approaches.

How to Test

For Mac:

Use the built in CLI:

• Set SETUP_CLI=true and run yarn start:desktop.
• The desktop client should prompt the app updater.

Use system CLI:

• Set SETUP_CLI=false and run yarn start:desktop.
• The desktop client should NOT prompt the app updater.

For Windows:

Notice in windows, we have the appUpdater disabled, so it will not be possible to test without code modifications.

Code modifications:

• Above this line add a console.log(isBuiltInCli: , boundaryCli.isBuiltInCli()).

Test procedure:

• Set SETUP_CLI=true and run yarn start:desktop. The console.log should show TRUE.
• Set SETUP_CLI=false and run yarn start:desktop. The console.log should show FALSE.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
boundary-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2024 7:40pm
boundary-ui-desktop	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2024 7:40pm