Closed lisbet-alvarez closed 2 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
boundary-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 28, 2024 11:17pm |
boundary-ui-desktop | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 28, 2024 11:17pm |
I am not understanding from the PR description underscore -> nomnom -> jsonlint
.
If I run yarn why jsonlint
the only result I get is from Rose, and we are actually resolving jsonlint
as dependency.
So I am confuse by your comment. Are you saying that underscore contains nommon which contains jsonlint? the resolution we have is the other way around **/nomnom/underscore
, can you please elaborate a bit? thank you
I follow up the breadcrumbs with micromatch, as despite we still need it today, if we perform an ember-cli
upgrade, most likely we will not need it anymore.
After deleting the resolution of micromatch, reinstalling deps and running yarn why micromatch
, you can see most deps that use micromatch
are using a version with no vulnerabilities 4.0.8
.
The only 2 deps that bring micromatch versions with security vulnerabilities, are dependencies from ember-cli
. I am not 100% sure, since needs to be checked, but I bet upgrading ember-cli
can solve this issue and the resolutions will not be need anymore.
I am not mentioning this to do perform that work now, but to audit with breadcrumbs, so we can asses how to get rid of the resolution in the future.
I am not understanding from the PR description
underscore -> nomnom -> jsonlint
.If I run
yarn why jsonlint
the only result I get is from Rose, and we are actually resolvingjsonlint
as dependency.So I am confuse by your comment. Are you saying that underscore contains nommon which contains jsonlint? the resolution we have is the other way around
**/nomnom/underscore
, can you please elaborate a bit? thank you
i write the dependencies backwards because its easier for me to understand that way, but it means that jsonlint
has nomnom
as a dep and nomnom
has underscore
as a dep. Apologies for the confusion.
I am not understanding from the PR description
underscore -> nomnom -> jsonlint
. If I runyarn why jsonlint
the only result I get is from Rose, and we are actually resolvingjsonlint
as dependency. So I am confuse by your comment. Are you saying that underscore contains nommon which contains jsonlint? the resolution we have is the other way around**/nomnom/underscore
, can you please elaborate a bit? thank youi write the dependencies backwards because its easier for me to understand that way, but it means that
jsonlint
hasnomnom
as a dep andnomnom
hasunderscore
as a dep. Apologies for the confusion.
Ahh gotcha! All good 😉
Description
Resolutions Audited:
loader-utils
babel-loader
to 9.2.1 which removesloader-utils
dep.babel-loader
version^8.0.6
to resolve to 8.4.1 which usesloader-utils
patched versionbabel-loader
is a dependency ofember-auto-import
minimatch
prismjs
underscore -> nomnom -> jsonlint
jsonlint
seems unmaintained we should replace but resolution still needed for nowtrim
micromatch
send
express
to recently released version fixes it.How to Test
boundary-ui-releases: test run
Checklist