hashicorp / boundary-ui

Monorepo for Boundary UIs and addons.
http://boundary-ui.vercel.app
Other
89 stars 29 forks source link

chore: 🤖 audit most recent resolutions #2531

Closed lisbet-alvarez closed 2 weeks ago

lisbet-alvarez commented 3 weeks ago

Description

Resolutions Audited:

How to Test

boundary-ui-releases: test run

Checklist

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 11:17pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 11:17pm
calcaide commented 3 weeks ago

I am not understanding from the PR description underscore -> nomnom -> jsonlint.

If I run yarn why jsonlint the only result I get is from Rose, and we are actually resolving jsonlint as dependency.

Screenshot 2024-10-22 at 1 09 18 PM

So I am confuse by your comment. Are you saying that underscore contains nommon which contains jsonlint? the resolution we have is the other way around **/nomnom/underscore, can you please elaborate a bit? thank you

calcaide commented 3 weeks ago

I follow up the breadcrumbs with micromatch, as despite we still need it today, if we perform an ember-cli upgrade, most likely we will not need it anymore.

After deleting the resolution of micromatch, reinstalling deps and running yarn why micromatch, you can see most deps that use micromatch are using a version with no vulnerabilities 4.0.8.

The only 2 deps that bring micromatch versions with security vulnerabilities, are dependencies from ember-cli. I am not 100% sure, since needs to be checked, but I bet upgrading ember-cli can solve this issue and the resolutions will not be need anymore.

Screenshot 2024-10-22 at 1 12 24 PM

I am not mentioning this to do perform that work now, but to audit with breadcrumbs, so we can asses how to get rid of the resolution in the future.

lisbet-alvarez commented 3 weeks ago

I am not understanding from the PR description underscore -> nomnom -> jsonlint.

If I run yarn why jsonlint the only result I get is from Rose, and we are actually resolving jsonlint as dependency. Screenshot 2024-10-22 at 1 09 18 PM

So I am confuse by your comment. Are you saying that underscore contains nommon which contains jsonlint? the resolution we have is the other way around **/nomnom/underscore, can you please elaborate a bit? thank you

i write the dependencies backwards because its easier for me to understand that way, but it means that jsonlint has nomnom as a dep and nomnom has underscore as a dep. Apologies for the confusion.

calcaide commented 3 weeks ago

I am not understanding from the PR description underscore -> nomnom -> jsonlint. If I run yarn why jsonlint the only result I get is from Rose, and we are actually resolving jsonlint as dependency. Screenshot 2024-10-22 at 1 09 18 PM So I am confuse by your comment. Are you saying that underscore contains nommon which contains jsonlint? the resolution we have is the other way around **/nomnom/underscore, can you please elaborate a bit? thank you

i write the dependencies backwards because its easier for me to understand that way, but it means that jsonlint has nomnom as a dep and nomnom has underscore as a dep. Apologies for the confusion.

Ahh gotcha! All good 😉