hashicorp / consul-k8s

First-class support for Consul Service Mesh on Kubernetes
https://www.consul.io/docs/k8s
Mozilla Public License 2.0
669 stars 322 forks source link

Add "automountServiceAccountToken" to the consul server serviceAccount #2011

Open mehta-ankit opened 1 year ago

mehta-ankit commented 1 year ago

Community Note


Is your feature request related to a problem? Please describe.

Allow a user to set automountServiceAccountToken on the serviceAccount. By default, the server pod mounts the API credentials token and I am just asking to make it explicit on the serviceAccount resource in this helm chart. Currently its not possible.

Feature Description

We have a requirement to set this key instead of getting the default behavior without knowing about it. to overcome this issueI could have created my own serviceAccount but this chart does not allow me to stop the creation of the serviceAccount in the chart . Even If I create my own I cannot provide it as a value to the server Statefulset (https://github.com/hashicorp/consul-k8s/blob/main/charts/consul/templates/server-statefulset.yaml#L138).

Use Case(s)

We are using consul as a kv store for Cortex.

Contributions

Yes, here is the contribution: https://github.com/hashicorp/consul-k8s/pull/1921

mehta-ankit commented 1 year ago

I have made a contribution to add this feature: https://github.com/hashicorp/consul-k8s/pull/1921 If it can be reviewed/merged soon , that would be appreciated 🙏🏼