search

hashicorp / consul-k8s

First-class support for Consul Service Mesh on Kubernetes
https://www.consul.io/docs/k8s
Mozilla Public License 2.0
668 stars 321 forks source link

Allow extra labels for Consul server statefulset VolumeClaimTemplate. #4386

Closed jv4n5e closed 1 week ago

jv4n5e commented 1 week ago

Overview of the Issue

--- When specifying extra labels under global.extraLabels in the values.yaml, they are not picked up by Helm.

Reproduction Steps

Steps to reproduce this issue, eg:

  1. Set any label under global.extraLabels.
  2. Do helm upgrade (-i).

I know how to fix it; the indentation of the labels stanza is 2 spaces short in the statefulset.yaml template file. I'll try to create a PR for this.

jv4n5e commented 1 week ago

It's not a bug, it's actually a feature request.