search

hashicorp / consul

Consul is a distributed, highly available, and data center aware solution to connect and configure applications across dynamic, distributed infrastructure.
https://www.consul.io
Other
28.31k stars 4.42k forks source link

Don't show "Service name will not be discoverable..." warning when DNS is disabled #12588

Open merge34 opened 2 years ago

merge34 commented 2 years ago

In our Consul setup (v.1.11.3), we have a lot of services with names that include underscores (like sth-with_underscore). Also, we do not use DNS at all, which means we set DNS port to -1 via the --dns-port -1 command line parameter. However, a lot of DNS warnings are printed into Consul logs concerning the names that are not valid for the DNS discovery:

[WARN] agent: Service name will not be discoverable via DNS due to invalid characters. Valid characters include all alpha-numerics and dashes.: service=sth-with_underscore

Feature Description

I suggest not to show the invalid name warning if the DNS is disabled (the DNS port is set to -1).

Use Case(s)

The feature will be helpful for users who don't use DNS in their Consul setups.

Amier3 commented 2 years ago

Hey @ibalashov24

A little late on the reply, but thanks for bringing this to our attention. I'm going to label this a 'good first issue' and 'help-wanted' to indicate that we'd like a community contributor to take this up. I think this would be a good first issue 😄

samajain commented 1 year ago

Hi @Amier3,

Can I work on this? I already have a solution ready and I have tested it too by creating a dummy service with an improper name.