Closed PurrBiscuit closed 5 years ago
Thanks for the Docker image for reproduction and for reporting.
@pearkes just checking in to see if there was anything more found out about this and if it appears to be a bug or something we can workaround for our restores. I did see in the linked issue that someone else had tried a restore
and it failed with the same error we're seeing as well. We're in a vulnerable spot with not being able to run a restore on our 1.2.4
Consul cluster should we need to.
@PurrBiscuit this should be fixed by https://github.com/hashicorp/consul/pull/5061. If you want to build that branch and give it a try with your repro that'd be great.
Note that if you're holding off on upgrading to 1.4.0 you could cherry-pick that commit back to 1.2.3+.
$ git fetch/clone/etc
$ git checkout v1.2.3
$ git cherry-pick 9f7e53f97657f4f190e10245541571a29a57ffec
$ make linux
@pearkes this fix isn't going to be making it to the 1.2
versions of consul? we could get upgraded to 1.4.0
in anticipation of this patch if it'll be limited to 1.4
versions. any idea what patch version this is being targeted for?
@PurrBiscuit the fix will be in 1.4.1.
This is a pretty tiny patch so the cherry-pick steps @pearkes gave would give a relatively easy way to test out without doing the full upgrade. We don't have a firm date for 1.4.1. yet so you may need to build from master anyway once this lands to test this out in the next week or so.
In general 1.4.0 was the first release where Connect was not a Beta feature and there are lots more stability and performance improvements to come for Connect in 1.4.x so I'd recommend getting there sooner rather than later if using Connect.
Thanks a lot for the quick response on this to everyone involved. We'll be getting upgraded to 1.4 across the board for our consul clusters. It's not a terribly urgent thing for us but if we do need to do a restore to our cluster we can do the steps outlined above to get a cluster with restore capabilities back up.
Fixed in https://github.com/hashicorp/consul/pull/5061! If you see further issues please let us know @PurrBiscuit.
We recently upgraded consul from
1.2.1
to1.2.4
and just started to see these errors in our consul-snapshot pipeline during a restore.Steps to reproduce: