search

hashicorp / faas-nomad

OpenFaaS plugin for Nomad
https://www.openfaas.com
MIT License
254 stars 46 forks source link

Mandatory update needed for `availableReplicas` #33

Closed alexellis closed 5 years ago

alexellis commented 6 years ago

(Thanks for reporting an issue! Please make sure you click the link above to view the issue guidelines, then fill out the blanks below.)

Hi Nic,

A mandatory update is needed for OpenFaaS providers to work with the newest changes proposed in the OpenFaaS UI.

A new field: availableReplicas will need to be populated in the endpoint /system/function/<name>

I found the code here:

https://github.com/hashicorp/faas-nomad/blob/914044bbf61ddebbc35d8b07a41d8cba2c5c7a95/handlers/replication.go#L44

Now the purpose of this field is to indicate which functions (containers) have a replica ready for a HTTP request - often when pulling a large image the function is not ready until several minutes in. That's the purpose of this change - to provide that information to the UI or new endpoint.

You may need to vendor the latest release of faas-provider, which adds a healthcheck endpoint also.

https://github.com/openfaas/faas-provider/releases

The easiest way to maintain compatibility will be to set the availableReplicas count to be the same as replicas - this will mean the UI continues to work as planned. Down the road updating availableReplicas to its true meaning would be best.

Let me know if you have questions or if I can help.

Alex

What are the steps to reproduce this issue?

n/a

What happens?

Invoke button will be permanently disabled

What were you expecting to happen?

Button to be enabled.

Any logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

N/a

Any other comments?

As above

What versions of software are you using?

Operating System: …

OpenFaaS Version: …

0.7.5 and higher.

Nomad Version: …

n/a

nicholasjackson commented 6 years ago

Just need to finish debugging the failing tests but this is pretty much good to go

alexellis commented 6 years ago

Thanks, I know you don't actively maintain this project so if you can get to it when you can that would help other potential nomad users.

alexellis commented 6 years ago

Bump

nicholasjackson commented 5 years ago

This has been all merged with pull request https://github.com/hashicorp/faas-nomad/pull/34

Cheers,

Nic