hashicorp / faas-nomad

OpenFaaS plugin for Nomad
https://www.openfaas.com
MIT License
255 stars 45 forks source link

basic auth + vagrant environment for integration testing #46

Closed acornies closed 6 years ago

acornies commented 6 years ago

Addresses: #43

Signed-off-by: Andrew Cornies acornies@gmail.com

alexellis commented 6 years ago

Do you have support for the KVM provisioner? I could try this on Linux if so.

acornies commented 6 years ago

Hi @alexellis I'll need to pull together a Linux host w/ Vagrant to test the libvirt provider reliably. Need another day or two.

acornies commented 6 years ago

Added basic auth to this PR which should address: #47

acornies commented 6 years ago

@alexellis I've added libvirt provider configuration to the Vagrantfile. If you can give it a go (assuming you have done the installation steps on your Linux host) that would be great. We might have to tweak what interface the provider uses for the private ip, but other than that, there should be no other modifications to the Vagrantfile to support KVM.

nicholasjackson commented 6 years ago

Hey, @acornies this looks great to me, ideally, I would prefer two separate pull requests for this as it is two distinct features, however, I am happy to merge this.

Keep up the great work