search

hashicorp / faas-nomad

OpenFaaS plugin for Nomad
https://www.openfaas.com
MIT License
254 stars 46 forks source link

[WIP] Issue 25 #49

Closed cpitkin closed 5 years ago

cpitkin commented 5 years ago

@nicholasjackson @acornies Can I get a check of my implementation. The implementation details are in Issue #25. I am having an issue setting up the tests to work with the new format. If either of you could make some suggestions on where I am going wrong that would be great.

cpitkin commented 5 years ago

I also just noticed I need to squash and rebase. I'll do that here in the next day or so.

acornies commented 5 years ago

Looks like this is still unfinished? Should probably not open a PR unless make test runs successfully on your machine (and tests aren't commented out). I suggest if you want a review of your implementation, provide a link to your fork/branch etc. before PR.

acornies commented 5 years ago

Hi @cpitkin , I've opened #56 which should supersede this one. I needed to tackle this for my company's dev environment as well as use the agent's configured DC instead of static dc1. Thanks for the understanding.

cpitkin commented 5 years ago

@acornies No worries. Thanks for making the update.