search

hashicorp / faas-nomad

OpenFaaS plugin for Nomad
https://www.openfaas.com
MIT License
255 stars 45 forks source link

Function secrets need default Vault policy #54

Closed acornies closed 5 years ago

acornies commented 5 years ago

What are the steps to reproduce this issue?

  1. Use the UI or faas-cli to deploy a function w/ one or more secrets using the Nomad provider

What happens?

Function is never "ready" due to missing Vault policy in certain Nomad configurations

What were you expecting to happen?

Functions can be deployed with secrets using Vault Nomad integration

Any logs, error output, etc?

N/A

Any other comments?

When a Nomad client is configured with a Vault master token this isn't a problem, but when Nomad Vault integration is configured to request token on-the-fly for functions (from the Nomad servers) a policy is needed to this behaviour to work.

What versions of software are you using?

Operating System: Ubuntu 16.04 x64

OpenFaaS Version: 0.9.3

Nomad Version: 0.8.4

nicholasjackson commented 5 years ago

Sorry @acornies just merged your PR, will do a tagged build in 10 mins

acornies commented 5 years ago

Resolved in #53