search

hashicorp / faas-nomad

OpenFaaS plugin for Nomad
https://www.openfaas.com
MIT License
254 stars 46 forks source link

Switch consul resolver to use ServiceAddress #83

Closed acornies closed 4 years ago

acornies commented 4 years ago

Signed-off-by: Andrew Cornies acornies@gmail.com

orefalo commented 4 years ago

Hi, can you maybe shed some light around this change? what's the benefit?

https://stackoverflow.com/questions/40756293/difference-between-consul-service-definition-address-and-service-address

acornies commented 4 years ago

Hi @orefalo This change facilitates faas-nomad on single-node instance w/ multiple interfaces (docker0 +) etc. I suspect this will be the same address as before in most use cases.

orefalo commented 4 years ago

Hi @acornies, that's what I understood from the link I provided, but glad you clarified. I also found you other repos; especially this one - https://github.com/acornies/faas-nomad-demos. battling vagrant (actually more vbox) on catalina at this point