search

hashicorp / field-workshops-terraform

Slide decks and Instruqt code for Terraform Workshops
Mozilla Public License 2.0
69 stars 64 forks source link

Some suggested improvements #65

Closed rberlind closed 4 years ago

rberlind commented 4 years ago

I have the following suggested improvements:

  1. It is bad practice to change the region of the AWS provider without first doing a destroy since it leaves orphan resources (a VPC in this case). We should find some other change to make. For instance, the tag could be added at this point.
  2. We should indicate that running Blast Radius runs terraform graph for us.
  3. When mentioning -J, we should also mention -J for Macs.
  4. The Instruqt Terminal tab should be called something different to avoid confusion.
  5. Quizes indicate that multiple answers can be given, but in second quiz, giving two answers gave error message saying too many answers given. This might be a limitation of Instruqt.
  6. The assignment for "Test and Repair" challenge has erroneous reference to a "resource group" which must be from Azure version of workshop. It should refer to "VPC".
  7. In the Add an Output challenge, I wonder if users will need hints or pointer that there are two ways of doing this: a) value = aws_instance.hashicat.public_ip or value = "${aws_instance.hashicat.public_ip}"
  8. The "Configure Remote State" challenge should tell user to edit remote_backend.tf to enter the organization and workspace before running init and apply.
scarolan commented 4 years ago

Moved the first into its own issue, #68

Added language to describe what terraform graph is and how it relates to Blast Radius.

We already mention CMD-J for mac, but i'll add it in again for emphasis

Renamed all Terminal tabs to "Classic Terminal", added note explaining what its for.

You're right on #5 and this has been reported to them already. 🤷‍♂

Good catch, and you're right, this was an artifact from copying the course. Fixed.

On #7, because we prepend the http:// to the URL, it has to have quotes. I'd prefer the student simply copy what's there and rename the output. I've added some language that should hopefully clarify this.

Number 8 has much more detailed instructions now on how to configure remote state.

Changes are in the feedback-fixes branch, expect a PR later today

scarolan commented 4 years ago

Fixed in #71