search

hashicorp / flight

Archived. The flight repo now lives in the design-system monorepo
https://github.com/hashicorp/design-system
11 stars 4 forks source link

Internal: jquery test scenario not passing #207

Closed MelSumner closed 3 years ago

MelSumner commented 3 years ago

jquery is still a test scenario in ember-try. It's currently not passing. We should figure out how to make it happy or remove it from the test scenario list.

Dhaulagiri commented 3 years ago

Is there a specific point at which it stopped passing? edit I ask because tests seem to be passing on main now

Dhaulagiri commented 3 years ago

It looks like something with the docs changes has introduced some flakiness in our tests

amyrlam commented 3 years ago

I also saw ember-release fail here: https://github.com/hashicorp/flight/pull/210

It should be solved by this https://github.com/hashicorp/flight/pull/209#discussion_r708645146, I may quickly try Percy today (and timebox) cause may be a better test anyways? Please LMK if I am missing something

MelSumner commented 3 years ago

I started noticing the flakiness after hooking up the toggle this morning. I might have inadvertently introduced a race condition, will need to track it down more.

amyrlam commented 3 years ago

This should be solved as I removed assert.dom('[data-test-target="icon-grid"] [data-test-icon]').exists(); which wasn't in the DOM https://github.com/hashicorp/flight/pull/209#discussion_r708645146. Removed as a part of the Percy test replacement https://github.com/hashicorp/flight/pull/211. It was that test failing thruout the various scenarios.

Please reopen if you see again though!

Dhaulagiri commented 3 years ago

I don't think this is actually solved as we are simply masking the problem by not testing for it now. We haven't actually solved the underlying issue with there being some unpredictable delay in how quickly the sprite gets loaded. Perhaps that's will be a moot point though if we need to change how the sprite is loaded for https://github.com/hashicorp/flight/issues/198

amyrlam commented 3 years ago

ok, this relates to https://github.com/hashicorp/flight/pull/209#discussion_r709262671 cause the only test failing was cause of the DOM thing? let me reopen and track that work here

amyrlam commented 3 years ago

i'll wait for https://github.com/hashicorp/flight/issues/31 to land