Closed johncowen closed 2 years ago
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/hashicorp/flight/6zSBdH2564UKo4A2Up6j1g23AYid
✅ Preview: https://flight-git-update-mappings-hashicorp.vercel.app
@heatherlarsen @cveigt assigned to you for review (and removed me and Hector, it's just a matter of checking the mapping).
K those extra ones are there @heatherlarsen whenever you get a sec, FYI I'm not blocked by this so no rush
Hey @heatherlarsen
I popped another commit on the end of here (sorry I know some folks prefer adding commits, and some prefer new PRs but figured for this new PR would be overkill)
@jnwright noticed that the mapping here for Structure's triangle (which by default is filled) is wrong as it points to Flights outlined variant. The triangle in the following image should be filled:
I updated the mapping and checked it locally:
I also noticed that the circle one here is probably wrong also, and I'm guessing there are possibly a few more, do you want me to just keep pushing on the end of here, or shall I make new PRs when we spot them?
ty!
@johncowen adding more fixes here is ok with me, if you find them.
I'm going to bring this in as-is for now. If there are additional changes feel free to send them along.
Note: I wasn't quite sure who to add as reviewer, please feel free to add any other relevant folks!
:pushpin: Summary
Updates the structure-mappings file to correct missing icons
:hammer_and_wrench: Detailed Description
N/A
:camera_flash: Screenshots
N/A
:link: External Links
N/A
:speech_balloon: Please consider using conventional comments when reviewing this PR.