search

hashicorp / flight

Archived. The flight repo now lives in the design-system monorepo
https://github.com/hashicorp/design-system
11 stars 4 forks source link

Consider fixing alphabetization of icons #417

Closed amyrlam closed 2 years ago

amyrlam commented 2 years ago
image

loading and running appear first.

Suggestion: Have the name on the Flight website be animation-loading and animation-running.

Edit: Seems like they're ordered by type, then alphabetical (e.g. slack is with other corporate icons). Not sure if intended or not.

MelSumner commented 2 years ago

Is this a bug? I am okay with having the animated ones first, and then the rest sorted alphabetically. Is there some sort of drawback to leaving it this way?

amyrlam commented 2 years ago

@MelSumner It's not just the animated ones that are out of order. Company ones are also out of order, sorted by type (e.g. waypoint before hashicorp before alert-circle:

image

For ~700 icons (and counting), not having a clear alphabetical order is arguably a bad user experience.

Clear alphabetical order provides more value to our users, vs random order that is not clear or specified on the page. Even specifying how they are ordered when you scroll, or labeling the "sections", could be an improvement.

I personally could not find the icons for the Feb newsletter yesterday. I defaulted to scrolling. This is not high priority, but there is room for improvement in my book. If the team decides to close the issue, is also a-ok.

Dhaulagiri commented 2 years ago

I think this makes sense and would be relatively easy to implement. Right now we're just spitting back out the order of the icons from the catalog.json file which is "sorted" based on where the different icons live on the figma side of things.

amyrlam commented 2 years ago

Can close as a won't do for now vs move to the new repo