Missing Enterprise_E200 sku with RedisEnterprise / API Version 2024-06-01-preview - Githubissues

hashicorp / go-azure-sdk

An opinionated Go SDK for Azure Resource Manager

Mozilla Public License 2.0

35 stars 46 forks source link

Missing Enterprise_E200 sku with RedisEnterprise / API Version 2024-06-01-preview #1121

Closed aiqiaoy closed 1 week ago

aiqiaoy commented 1 week ago

Is there an existing issue for this?

[x] I have searched the existing issues

Community Note

Please vote on this issue by adding a :thumbsup: reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Service Used

Redis Enterprise

API Versions Used

2024-06-01-preview

Description

2024-06-01-preview is missing Enterprise_E200 sku which was supported in 2023-10-01-preview

https://github.com/hashicorp/go-azure-sdk/blob/2c82270fdd193c987ed3632082806e3c6fe000c1/resource-manager/redisenterprise/2024-06-01-preview/redisenterprise/constants.go#L646-L658

https://github.com/hashicorp/go-azure-sdk/blob/2c82270fdd193c987ed3632082806e3c6fe000c1/resource-manager/redisenterprise/2023-10-01-preview/redisenterprise/constants.go#L613

References

No response

stephybun commented 1 week ago

Hey @aiqiaoy,

This SDK is generated by hashicorp/Pandora which consumes the Microsoft Rest API Specs. Looking at the spec the issue seems to be that the upstream data doesn't define the Enterprise_E200 sku anymore

2023-10-01-preview https://github.com/Azure/azure-rest-api-specs/blob/2afa5b356adf6cf51209d2cf28d38644c69d9832/specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2023-10-01-preview/redisenterprise.json#L1918-L1929

2024-06-01-preview https://github.com/Azure/azure-rest-api-specs/blob/2afa5b356adf6cf51209d2cf28d38644c69d9832/specification/redisenterprise/resource-manager/Microsoft.Cache/preview/2024-06-01-preview/redisenterprise.json#L1405-L1415

I'm going to close this since we can't add this missing sku into the definition as it would just be overwritten by the generation, but I would suggest opening an issue on Azure/azure-rest-api-specs to get this added or looked at.