search

hashicorp / go-discover

Discover nodes in cloud environments
Mozilla Public License 2.0
563 stars 123 forks source link

Allow setting a endpointURL on AWS provider #108

Open jorgemarey opened 5 years ago

jorgemarey commented 5 years ago

Fixes #107

melan commented 5 years ago

@pearkes @jorgemarey do you plan to move forward with this change? I will be really helpful to have it merged and available in Consul eventually

jorgemarey commented 5 years ago

Hi @melan. Just updated the PR with the requested changes. We found out that for our case this wasn't needed because we could set the enpoint private_dns value to true, so the internally the public DNS resolves the direction of the EC2 endpoint. But this change should work in other cases where the private_dns property can't be set on the endpoint.

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.