search

hashicorp / go-discover

Discover nodes in cloud environments
Mozilla Public License 2.0
563 stars 123 forks source link

Digitalocean multitags #124

Open abaez opened 5 years ago

abaez commented 5 years ago

While working #112, I noticed that the multi tags ability was also missing for another service provider I tend to use; DigitalOcean. I have gone ahead and added the ability.

Also included in this PR is a small change to discover a node if the node has only a public IP on DigitalOcean. Since DigitalOcean's private network isn't always enabled, a node that doesn't have a private IP on DigitalOcean wouldn't be matched regardless of its tag match. The change here is to fall back to check for the public IP when the private IP is not available.

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.