search

hashicorp / go-discover

Discover nodes in cloud environments
Mozilla Public License 2.0
563 stars 123 forks source link

add provider implementations of tencentcloud #125

Closed likexian closed 4 years ago

likexian commented 5 years ago

Hello,

This PR provides a new provider implementations of TencentCloud in the go-discover/provider sub packages.

About TencentCloud

Tencent Cloud is a secure, reliable and high-performance cloud compute service provided by Tencent. It is the 2st largest Cloud Provider in China.

likexian commented 5 years ago 
go test -v ./provider/tencentcloud/
=== RUN   TestAddrs
2019/09/02 19:57:59 [DEBUG] discover-tencentcloud: Using region=ap-guangzhou, tag_key=consul, tag_value=test
2019/09/02 19:57:59 [DEBUG] discover-tencentcloud: Static credentials provided
2019/09/02 19:57:59 [DEBUG] discover-tencentcloud: region is ap-guangzhou
2019/09/02 19:57:59 [DEBUG] discover-tencentcloud: address type is private_v4
2019/09/02 19:57:59 [DEBUG] discover-tencentcloud: Filter instances with consul=test
2019/09/02 19:58:00 [DEBUG] discover-tencentcloud: Found 2 instances
2019/09/02 19:58:00 [DEBUG] discover-tencentcloud: Instance ins-kj81nmyo has private_v4 172.16.0.26
2019/09/02 19:58:00 [DEBUG] discover-tencentcloud: Instance ins-qgatl4is has private_v4 172.16.0.76
2019/09/02 19:58:00 [DEBUG] discover-tencentcloud: Found address: [172.16.0.26 172.16.0.76]
--- PASS: TestAddrs (0.41s)
PASS
ok      github.com/hashicorp/go-discover/provider/tencentcloud  0.423s
hanshasselberg commented 5 years ago

Thank you @likexian for your work! We will have a look soon!

likexian commented 5 years ago

Hello, Would someone please take a review of this PR?

alvin-huang commented 4 years ago

I hooked this up to our CI with credentials for Tencentcloud and it passed the provider tests. @hashicorp/consul-core can someone have a look through the Go code?

likexian commented 4 years ago

Hello @banks Thank you for your help, I have resolved the issue about dependency.

The testing after changed passed, please have a review.

=== RUN   TestAddrs
2019/11/19 10:36:48 [DEBUG] discover-tencentcloud: Using region=ap-guangzhou, tag_key=consul, tag_value=test
2019/11/19 10:36:48 [DEBUG] discover-tencentcloud: Static credentials provided
2019/11/19 10:36:48 [DEBUG] discover-tencentcloud: region is ap-guangzhou
2019/11/19 10:36:48 [DEBUG] discover-tencentcloud: address type is private_v4
2019/11/19 10:36:48 [DEBUG] discover-tencentcloud: Filter instances with consul=test
2019/11/19 10:36:49 [DEBUG] discover-tencentcloud: Found 2 instances
2019/11/19 10:36:49 [DEBUG] discover-tencentcloud: Instance ins-i7ugrga0 has private_v4 172.16.0.144
2019/11/19 10:36:49 [DEBUG] discover-tencentcloud: Instance ins-ju9pzua2 has private_v4 172.16.0.90
2019/11/19 10:36:49 [DEBUG] discover-tencentcloud: Found address: [172.16.0.144 172.16.0.90]
--- PASS: TestAddrs (0.88s)
PASS
ok      github.com/hashicorp/go-discover/provider/tencentcloud  0.939s