search

hashicorp / go-discover

Discover nodes in cloud environments
Mozilla Public License 2.0
563 stars 123 forks source link

Update k8s.io/client-go dependency #143

Closed mkeeler closed 4 years ago

mkeeler commented 4 years ago

Tests and things currently will not run in module mode (Go Path mode is fine) after #139 was merged. I wanted to see if updating the k8s.io/client-go dependency would still run properly with integration tests. If it does we might be able to merge this.

mkeeler commented 4 years ago

Our tf for spinning up the k8s infra is causing tf to crash 😞. So its a little hard to determine if these updates are okay.

mkeeler commented 4 years ago

This updates our k8s.io/client-go dependency to the kubernetes-1.16.9 tag.

We are using a kubernetes-1.x.y tag instead of a vX.Y.Z tag to maintain support for older kubernetes versions.

We are using 1.16.9 instead of 1.17.* or 1.18.* in order to allow go-discover to still compile with Go 1.11.

So we aren't on the latest but its much newer than before and fixes go mod versioning incompatibilities with the recent azure sdk library updates.