search

hashicorp / go-discover

Discover nodes in cloud environments
Mozilla Public License 2.0
563 stars 123 forks source link

provider/hcloud: Add hcloud discovery #159

Closed shortner closed 3 years ago

shortner commented 4 years ago

This Pull Request add the Implementation of the hcloud (Hetzner Cloud) provider.

Usage

Hetzner Cloud:

    provider:       "hcloud"
    api_token:      The Hetzner CLoud API token to use (required)
    label_selector: The label selector to filter servers by
    addr_type:      "private_v4", "public_v4" or "public_v6". Defaults to "private_v4". If multiple private networks are defined, the first will be used.
hashicorp-cla commented 4 years ago

CLA assistant check
All committers have signed the CLA.

marco-m commented 4 years ago

@ashwin-venkatesh @alvin-huang any chance you could review this PR ? Do you have somebody else from HashiCorp to suggest ? Thanks!

thisisnotashwin commented 4 years ago

Hey @marco-m ,

Thanks for bringing this to my attention. This does look good based on a first pass. Having said that, I'd defer to @dnephin as he is far more familiar with this repo.

alvin-huang commented 4 years ago

This LGTM but I would like another look from someone on @hashicorp/consul-core in case I missed something.

marco-m commented 4 years ago

Thanks to all the HashiCorp team for the kind and quick reaction :-) @shortner we are almost there, would you have time to follow up the reviews ?

shortner commented 4 years ago

Thanks for the review. I have adapted the notes and committed the adjustments.

svenstaro commented 4 years ago

Any chance this could be merged now? I'm very much looking forward to this. :)

Fixes #73.

Thunderbottom commented 3 years ago

Seems like the owner of this pull request is an inactive GitHub user. With all respect to the dev, I have opened a pull request that includes some fixes and enhancements over this PR. I hope it can be merged soon :)