Feature/aws ecs support

[fdr2]

Description

Add ECS support to AWS Go-Discover plugin.

Fixes: 6802 Revives/Simplifies PR #54

Note: in order to build and test this change I needed PR #184 to fix #183

PR Checklist

• [X] updated test coverage
• [ ] external facing docs updated
• [X] not a security concern

[Amier3]

Hey @fdr2

Thanks for taking this up! We'll get this reviewed and merged in soon. Afterwards we'll have to update go-discover in the consul repo, so this won't be reflected in the main branch until the next patch release.

The team did want to caution though that we haven't evaluated the effects of running consul servers inside of ECS ( aside from a single node cluster for dev/testing ) . So for the moment we only officially support using servers outside of ECS. There was a couple of factors that went into that decision -- one of them being some performance concerns around the EFS that ECS uses under the hood.

Regardless, we're still cool with this as an experimental feature so please report back on the main consul repo sometime & let us know how this is working for you 👍 😄

[fdr2]

Thanks @Amier3 I didn't mean to go against the grain 😅 It seemed like a common topic and I really enjoyed digging through go-discover to implement it. If you happen to know any way I can benchmark consul or what the particular performance concerns may be on ecs-efs I would be interesting in digging in deeper.

[pglass]

Thanks @fdr2! To enable use of this in Consul, the next step is to open a PR to bump the library version in the consul repo.

[fdr2]

Thanks @pglass & @Amier3 for all your help getting this merged. I should be able to jump on the consul pr later today :D