search

hashicorp / go-getter

Package for downloading things from a string URL using a variety of protocols.
Mozilla Public License 2.0
1.62k stars 226 forks source link

Add support for NTLM into HTTP getter #435

Closed 0x4c6565 closed 1 year ago

0x4c6565 commented 1 year ago

Adds support for NTLM authentication into HTTP getter

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

crw commented 1 year ago

Thanks for this submission! Is there a bug where the use case for this change is discussed? Is it targeting a particular product (e.g. Terraform, Nomad, etc)?

0x4c6565 commented 1 year ago

My specific use case for this was with Packer, and trying to access an ISO hosted on a Windows server. This server only has Windows authentication enabled, with basic auth explicitly disabled.

I have since found that this implementation does actually violate the intended implementation of http.Roundtripper, and it'd be better to instead wrap http.Client.

I'll close this and open an issue to discuss whether adding this functionality is desirable before opening another PR