Noticed that in helper/url/url.go you are using "net/url" to parse, but as far as I know, it does not support parsing all supported protocols formats such as:
gcs::https://www.googleapis.com/storage/v1/bucket1/foo.img
The parsed url.URL output will have:
Scheme as gcs
Opaque as :https://www.googleapis.com/storage/v1/bucket1/foo.img
everything else is either an empty string, false or nil
This is causing the client's GetChecksum call to fail because if the checksum is of a similar format, for example file:gcs::https://www.googleapis.com/storage/v1/bucket1/SHA256SUMS, it will pass the request Src to parse and pass the empty string as the checksummedPath to the checksumFromFile call which will cause it to not find any suitable checksum.
Hello,
Noticed that in
helper/url/url.goyou are using"net/url"to parse, but as far as I know, it does not support parsing all supported protocols formats such as:gcs::https://www.googleapis.com/storage/v1/bucket1/foo.imgThe parsedurl.URLoutput will have:gcs:https://www.googleapis.com/storage/v1/bucket1/foo.imgThis is causing the client's GetChecksum call to fail because if the checksum is of a similar format, for example
file:gcs::https://www.googleapis.com/storage/v1/bucket1/SHA256SUMS, it will pass the request Src to parse and pass the empty string as thechecksummedPathto thechecksumFromFilecall which will cause it to not find any suitable checksum.Please fix.
Thanks,