hashicorp / go-getter

Package for downloading things from a string URL using a variety of protocols.
Mozilla Public License 2.0
1.65k stars 232 forks source link

Breaking checksum validation changes from 1.5.1 -> 1.7.0? #487

Open clarkmcc opened 5 months ago

clarkmcc commented 5 months ago

As noted in the title, I upgraded from 1.5.1 to 1.7.0. I'm using go-getter to download files via HTTP from a GCS storage bucket (using HTTP links, not GCS links). The files are gzipped. I'm passing an MD5 checksum in the URI that I pass to go-getter. We've used this to download 100,000+ of gzipped files without issue but the first three tests with 1.7.0 all failed with this error

downloading file: Checksums did not match for C:\WINDOWS\TEMP\getter1394060914\archive. 
  Expected: 0a484cb6eceddd120f71b35e3b53dcd1 
  Got: e98f92dfdb1a93ce2064a41843a73501

Did anything change regarding how checksums are calculated, or possibly anything else that could produce this error on 1.7.0 but not on 1.5.1?