search

hashicorp / go-getter

Package for downloading things from a string URL using a variety of protocols.
Mozilla Public License 2.0
1.62k stars 227 forks source link

fix: #479 allow nested repos for gitlab.com #494

Open tvizor opened 1 month ago

tvizor commented 1 month ago

Address #479 As per GitLab documentation, repositories can be nested under projects and subgroups: https://docs.gitlab.com/ee/user/group/subgroups/

MR is to remove the limit of 3 components of the path (gitlab.com/username/repo) and allow referencing paths to directories inside the repo.

Parse must be performed on the whole URL before evaluating and adding the .git suffix to the repo name to keep the ref query in its original format (?ref=master vs %3Fref=master if parsed as a part of the path).

hashicorp-cla-app[bot] commented 1 month ago

CLA assistant check
All committers have signed the CLA.

gmaghera commented 1 month ago

Could we get someone to review this change, please?