search

hashicorp / go-getter

Package for downloading things from a string URL using a variety of protocols.
Mozilla Public License 2.0
1.66k stars 239 forks source link

fix: #479 allow nested repos for gitlab.com #494

Open tvizor opened 6 months ago

tvizor commented 6 months ago

Address #479 As per GitLab documentation, repositories can be nested under projects and subgroups: https://docs.gitlab.com/ee/user/group/subgroups/

MR is to remove the limit of 3 components of the path (gitlab.com/username/repo) and allow referencing paths to directories inside the repo.

Parse must be performed on the whole URL before evaluating and adding the .git suffix to the repo name to keep the ref query in its original format (?ref=master vs %3Fref=master if parsed as a part of the path).

hashicorp-cla-app[bot] commented 6 months ago

CLA assistant check
All committers have signed the CLA.

gmaghera commented 5 months ago

Could we get someone to review this change, please?

crw commented 4 months ago

I am not sure why I am only now seeing this notification in GitHub, but I will raise this in triage. I find this comment interesting, https://github.com/gruntwork-io/terragrunt/issues/3031#issuecomment-2214576840, will see what is underneath that difference. To set expectations, there is a strong headwind to getting PRs reviewed and merged into this repo due to multiple products using it and an unwillingness to inadvertently add new bugs. In any case, thanks for the submission!