search

hashicorp / go-multierror

A Go (golang) package for representing a list of errors as a single error.
Mozilla Public License 2.0
2.3k stars 123 forks source link

Fix travis setup to work with go modules #19

Closed joac closed 3 years ago

joac commented 5 years ago

Just to get the build passing again!

I followed: https://dave.cheney.net/2018/07/16/using-go-modules-with-travis-ci and: https://arslan.io/2018/08/26/using-go-modules-with-vendor-support-on-travis-ci/

hoenirvili commented 5 years ago

@joac I think you also need to sign the licence/cla agreement in order to make everything pass.

hoenirvili commented 5 years ago

@mitchellh Could you please review this?

jefferai commented 5 years ago

Unfortunately we need the CLA signed before we can proceed.

hoenirvili commented 5 years ago

@jefferai I know this PR is old, I could sign the CLA and then open a separate PR including these changes.

joac commented 5 years ago

Done, sorry for the delay

hoenirvili commented 5 years ago

@joac It stills says that the licence/cla is pending. Are you sure that you sign the agreement?

joac commented 5 years ago

I signed it, but is not updating :(

On Wed, Mar 20, 2019, 3:43 AM Hœnir notifications@github.com wrote:

@joac https://github.com/joac It stills says that the licence/cla is pending. Are you sure that you sign the agreement?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hashicorp/go-multierror/pull/19#issuecomment-474706685, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHvQzjyhhpMxEBVQWlxcBIxhS_SCOXdks5vYdiQgaJpZM4X6c-v .

hoenirvili commented 5 years ago

@jefferai How can this issue with the license can be resolved in order to merge this?

jefferai commented 5 years ago

Sorry about that, I've poked the responsible people, hopefully it will be resolved on Monday

hashicorp-cla commented 5 years ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Joaquín Sorianello seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

jfreda commented 5 years ago

👋 Hi @joac ! Can you please make sure that the email address that you used to author your PR commit is associated with your GitHub user? You might either need to add it to your GitHub email settings or rebase to create a different commit with a valid email address so the CLA check goes through. Thanks!