Use pointers for receiver methods implementing the sort interface

hashicorp / go-multierror

A Go (golang) package for representing a list of errors as a single error.

Mozilla Public License 2.0

2.34k stars 123 forks source link

Use pointers for receiver methods implementing the sort interface #20

Closed dhui closed 5 years ago

dhui commented 5 years ago

All other Error receiver methods use pointers

hashicorp-cla commented 5 years ago

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

mitchellh commented 5 years ago

At this point we already shipped with this decision and we don't want to break compatibility. It probably should've been a pointer receiver but its fairly cheap to do the copy here.