hashicorp / go-plugin

Golang plugin system over RPC.
Mozilla Public License 2.0
5.25k stars 450 forks source link

fix: typo in plugin name #174

Closed mirogta closed 2 years ago

mirogta commented 3 years ago

The example didn't work for me because the plugins register name "kv" but the main code expected "kv_grpc".

Changing the name to "kv" here fixed the examples for me.

hashicorp-cla commented 3 years ago

CLA assistant check
All committers have signed the CLA.

fairclothjm commented 2 years ago

@mirogta That is not a typo. The kv_grpc PluginMap entry is defined here:

https://github.com/hashicorp/go-plugin/blob/044aadd925bf9f027cb301b2af9bc6b60775dd22/examples/grpc/shared/interface.go#L22-L26