search

hashicorp / go-plugin

Golang plugin system over RPC.
Mozilla Public License 2.0
5.25k stars 450 forks source link

Fix examples/basic/commons go package name #214

Closed niulechuan closed 2 years ago

niulechuan commented 2 years ago

Fix examples/basic/commons go package name

Package name "commons" is more explicit in "commons" dir than "example".

hashicorp-cla commented 2 years ago

CLA assistant check
All committers have signed the CLA.

niulechuan commented 2 years ago

Cc: @fairclothjm PTAL, thanks!

fairclothjm commented 2 years ago

@niulechuan Hi, thanks for the PR! I wonder if it would make more sense to change commons->shared to align more with the other examples. See https://github.com/hashicorp/go-plugin/tree/master/examples/grpc/shared.

Also, don't forget to update the code examples in https://github.com/hashicorp/go-plugin/blob/master/docs/extensive-go-plugin-tutorial.md

niulechuan commented 2 years ago

@niulechuan Hi, thanks for the PR! I wonder if it would make more sense to change commons->shared to align more with the other examples. See https://github.com/hashicorp/go-plugin/tree/master/examples/grpc/shared.

Also, don't forget to update the code examples in https://github.com/hashicorp/go-plugin/blob/master/docs/extensive-go-plugin-tutorial.md

Absolutely! Done