hashicorp / go-plugin

Golang plugin system over RPC.
Mozilla Public License 2.0
5.25k stars 450 forks source link

remove logging for missing `SecureConfig` #238

Closed tgross closed 1 year ago

tgross commented 1 year ago

In #207 we introduced a warning if the SecureConfig is unset. For Nomad and other applications that have "internal" go-plugin consumers where the application runs itself as a plugin, this causes spurious warn-level logs. For Nomad in particular this means every task driver and logmon invocation emits the log, which is our primary operation.

Setting a SecureConfig isn't required, and if a given go-plugin consumer requires it to be, this seems more like a programming error than a runtime error. Remove the log line.

Ref https://github.com/hashicorp/nomad/issues/16288