hashicorp / go-plugin

Golang plugin system over RPC.
Mozilla Public License 2.0
5.25k stars 450 forks source link

add DialOptions to GRPCBroker's Dial #251

Closed alexandreLamarre closed 3 days ago

alexandreLamarre commented 1 year ago

Motivation

Spiritual successor to : #168

For purpose built client-side interceptors, there can be a need to control which plugins get certain interceptors and this currently isn't possible with GRPCBroker's Dial(id uint32) signature or using "global" dialOpts in the plugin Client Config struct (without changing existing plugin structures to use multiple client instances)

Client-side change

The underlying dial implementation in Dial(id uint32) accepts ...grpc.DialOption so I propose :

Dial(id uint32, dialOpts ...grpc.DialOption) for more fine grained control over GRPCBroker connections.

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

robmonte commented 3 days ago

Closed by #257