search

hashicorp / go-plugin

Golang plugin system over RPC.
Mozilla Public License 2.0
5.25k stars 450 forks source link

GRPCBroker: add DialWithOptions #257

Closed jmank88 closed 1 month ago

jmank88 commented 1 year ago

When creating new clients and servers with a type GRPCBroker, grpc.ServerOptions can be added when using Accept(id uint32) and AcceptAndServe(id uint32, s func([]grpc.ServerOption) *grpc.Server), but grpc.DialOptions cannot be added when using Dial(id uint32).

This PR proposes adding a DialWithOptions(id uint32, opts ...grpc.DialOption) method.

Note: Dial could be updated in place without affecting typical uses, but the signature change would still be breaking.

- Dial(id uint32)
+ Dial(id uint32, opts ...grpc.DialOption)

(this is the approach proposed in #251)

hashicorp-cla commented 1 year ago

CLA assistant check
All committers have signed the CLA.

jmank88 commented 8 months ago

Rebased muxer conflicts.

jmank88 commented 1 month ago

@tomhjp @VioletHynes Is someone available to consider this feature (or #251)? :pray:

VioletHynes commented 1 month ago

Hey! This seems super reasonable. Thanks for raising this. I'll try and get somebody's eyes on this shortly.