search

hashicorp / go-plugin

Golang plugin system over RPC.
Mozilla Public License 2.0
5.25k stars 450 forks source link

Revert "Add context argument to runner methods that do work" #274

Closed jefferai closed 1 year ago

jefferai commented 1 year ago

Reverts hashicorp/go-plugin#273

This changed a public API without an associated bump in the API version, violating go module rules.

jefferai commented 1 year ago

Never mind, I didn't notice that runner was also brought in via unreleased code until I saw some older notifications.

In the future it might be good to be more explicit about that in the commit message, otherwise people simply seeing an API change may not understand whether it's to already-released code or not.

tomhjp commented 1 year ago

👍 that's correct - I've tried to take my time tagging because of the backwards compatibility commitment I'll be making. I made a note about that for my last intended change before tagging in #275