hashicorp / go-retryablehttp

Retryable HTTP client in Go
Mozilla Public License 2.0
1.99k stars 251 forks source link

Fix body nil checking in NewRequest #120

Open Dorokhov opened 3 years ago

Dorokhov commented 3 years ago

NewRequest accepts interface{} as body argument but doesn't check it on nil properly. It should check that not only variable is nil, but also pointer value is nil. Otherwise it constructs different Request objects for the same parameters. Tests are added.

hashicorp-cla commented 3 years ago

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Volodymyr Dorokhov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.