hashicorp / go-retryablehttp

Retryable HTTP client in Go

Mozilla Public License 2.0

1.99k stars 251 forks source link

kmartin/Add support for RFC1123 Date/Time in Retry-After header. #130

Closed kevinmartin closed 6 months ago

kevinmartin commented 3 years ago

What?

The Retry-After header can have a numerical value that denotes how long a client should wait before retrying or a date/time value that denotes when a client a client should retry.
This PR adds the ability to attempt to parse a date/time value if it is non-numerical.

hashicorp-cla commented 3 years ago

All committers have signed the CLA.

palczyn commented 3 years ago

Hey, is this feature going to be merged soon?

justenwalker commented 3 years ago

I opened #144 for discussion about the feature. Given that there are now 3 PRs that accomplish the same thing, we should probably consolidate discussion in a single place.

manicminer commented 6 months ago

@kevinmartin Thanks for submitting this PR. I appreciate this has been outstanding for a long time, however I'm going to merge #138 for this functionality as that has additional safety checks on the resulting duration after parsing. Thanks again for working on this.

manicminer commented 6 months ago

Duplicate of #138