hashicorp / go-retryablehttp

Retryable HTTP client in Go
Mozilla Public License 2.0
1.99k stars 251 forks source link

Reason behind closing all idle connections aggresively #237

Open pg30 opened 1 month ago

pg30 commented 1 month ago

Hey, I was trying to understand the flow of Do function and noticed that all idle connections are being closed if we are not able to read the request body or if all retries are exhausted and we still have an error.

Can't we selectively close the current connection that is causing problems rather than closing all the good connections that can be reused for subsequent requests to the same host.

I am trying to understand the reasoning behind this as we are going to integrate this lib in production service with a high throughput and I am uncomfortable with the impact of closing idle connections.

TIA for helping me out.