search

hashicorp / go-secure-stdlib

Mozilla Public License 2.0
64 stars 24 forks source link

Update AWS-SDK-GO to v1.38.42 at minumum, but ideally to latest (v1.43.17) in awsutil #34

Closed bengaywins closed 11 months ago

bengaywins commented 2 years ago

Is your feature request related to a problem? Please describe. AWS Golang SDK is old and so does not support AWS SSO credentials without a special credential_process.

Describe the solution you'd like The SDK updated and the ability to use SSO credentials normally

Describe alternatives you've considered None. This is a non-starter because this is related to Vault supporting SSO creds through the use of this awsutil library that seemingly has been neglected for updates to the AWS SDK.

Additional context We are trying to transition all our users to use AWS SSO (backed by JumpCloud) but Vault auth doesn't support it due to this library using the AWS SDK from two years ago.

jorhett commented 11 months ago

https://github.com/aws/aws-sdk-go/issues/4989 is critical for SSO users, which means we need at least v1.45.15.

bengaywins commented 11 months ago

That was the primary reason I opened this. I even had originally started working on a PR but things got in the way.

bengaywins commented 11 months ago

@jorhett it looks like that this was actually updated to use the -v2 version of the SDK on Sept 21st. So this issue is truly resolved. The issue now is that Vault needs to update to use the new v2.0.0 release. As such, I am going to close this as my issue would technically be resolved in this library.

fixed in #83